Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build(deps): bump actions/checkout from 4.2.0 to 4.2.2 #1585

Merged
merged 1 commit into from
Mar 27, 2025
Merged

build(deps): bump actions/checkout from 4.2.0 to 4.2.2 #1585

merged 1 commit into from
Mar 27, 2025
+3 −3

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Oct 28, 2024 •
edited
Loading

Bumps actions/checkout from 4.2.0 to 4.2.2.

Release notes

Sourced from actions/checkout's releases.

v4.2.2

What's Changed

Full Changelog: actions/checkout@v4.2.1...v4.2.2

v4.2.1

What's Changed

New Contributors

Full Changelog: actions/checkout@v4.2.0...v4.2.1

Changelog

Sourced from actions/checkout's changelog.

Changelog

v4.2.2

v4.2.1

v4.2.0

v4.1.7

v4.1.6

v4.1.5

v4.1.4

v4.1.3

v4.1.2

v4.1.1

v4.1.0

... (truncated)

Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot added dependencies Pull requests that update a dependency file github_actions Pull requests that update GitHub Actions code labels Oct 28, 2024
@dependabot dependabot bot mentioned this pull request Oct 28, 2024
Closed
@dependabot dependabot bot requested review from dgrisonnet and s-urbaniak October 28, 2024 12:03
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Oct 28, 2024
@k8s-ci-robot k8s-ci-robot added needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Oct 28, 2024
@k8s-ci-robot
Copy link
Contributor

Hi @dependabot[bot]. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 28, 2024
@richabanker
Copy link

/triage accepted
/assign @dgrisonnet

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Oct 31, 2024
yangjunmyfm192085
yangjunmyfm192085 reviewed Nov 22, 2024
View reviewed changes
Copy link
Contributor

@yangjunmyfm192085 yangjunmyfm192085 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Nov 22, 2024
yangjunmyfm192085
yangjunmyfm192085 approved these changes Nov 22, 2024
View reviewed changes
Copy link
Contributor

@yangjunmyfm192085 yangjunmyfm192085 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 22, 2024
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

  • Mark this PR as fresh with /remove-lifecycle stale
  • Close this PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Feb 20, 2025
@RainbowMango
Copy link
Member

/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Mar 11, 2025
@RainbowMango
Copy link
Member

Once this PR has been reviewed and has the lgtm label, please ask for approval from dgrisonnet. For more information see the Kubernetes Code Review Process.

/assign @dgrisonnet
for approval
Thanks

@dgrisonnet
Copy link
Member

/approve

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 12, 2025
@RainbowMango
Copy link
Member

/retest

@RainbowMango
Copy link
Member

@dependabot rebase

@dependabot Dependabot
Copy link
Contributor Author

dependabot bot commented on behalf of github Mar 13, 2025

Sorry, only users with push access can use that command.

@RainbowMango
Copy link
Member

Not sure why the tests is failing yet, just echo the logs here:

+ WRAPPED_COMMAND_PID=17
+ wait 17
+ make verify
go install -mod=readonly -modfile=scripts/go.mod github.com/google/addlicense
go: downloading github.com/google/addlicense v1.1.1
go: downloading github.com/bmatcuk/doublestar/v4 v4.0.[2](https://prow.k8s.io/view/gs/kubernetes-ci-logs/pr-logs/pull/kubernetes-sigs_metrics-server/1585/pull-metrics-server-verify/1899993781495664640#1:build-log.txt%3A2)
go: downloading golang.org/x/sync v0.7.0
find -type f -name "*.go" ! -path "*/vendor/*" | xargs /home/prow/go/bin/addlicense -check || (echo 'Run "make update"' && exit 1)
curl -sSfL https://raw.githubusercontent.com/golangci/golangci-lint/master/install.sh | sh -s -- -b /home/prow/go/bin v1.61.0
golangci/golangci-lint info checking GitHub for tag 'v1.61.0'
golangci/golangci-lint info found version: 1.61.0 for v1.61.0/linux/amd64
golangci/golangci-lint info installed /home/prow/go/bin/golangci-lint
/home/prow/go/bin/golangci-lint run --timeout 10m || (echo 'Run "make update"' && exit 1)
level=warning msg="The linter 'exportloopref' is deprecated (since v1.60.2) due to: Since Go1.22 (loopvar) this linter is no longer relevant. Replaced by copyloopvar."
pkg/api/pod_test.go:[3](https://prow.k8s.io/view/gs/kubernetes-ci-logs/pr-logs/pull/kubernetes-sigs_metrics-server/1585/pull-metrics-server-verify/1899993781495664640#1:build-log.txt%3A3)4:11: could not import k8s.io/apimachinery/pkg/types (-: could not load export data: internal error in importing "k8s.io/apimachinery/pkg/types" (unsupported version: 2); please report an issue) (typecheck)
	apitypes "k8s.io/apimachinery/pkg/types"
	         ^
pkg/api/node.go:[8](https://prow.k8s.io/view/gs/kubernetes-ci-logs/pr-logs/pull/kubernetes-sigs_metrics-server/1585/pull-metrics-server-verify/1899993781495664640#1:build-log.txt%3A8)9:3: undefined: klog (typecheck)
		klog.ErrorS(err, "Failed reading nodes metrics")

@RainbowMango
Copy link
Member

@dgrisonnet Can you help to rebase this PR?

@dgrisonnet
Copy link
Member

@dependabot rebase

@dependabot dependabot bot force-pushed the dependabot/github_actions/actions/checkout-4.2.2 branch from 957e4be to 838f0a6 Compare March 18, 2025 14:47
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 18, 2025
@dgrisonnet
Copy link
Member

seems like this update needs to be done manually

@RainbowMango
Copy link
Member

I will explore it, just curious this check should not fail, because this PR just updates the action.

@RainbowMango
Copy link
Member

getting hash for artifact "gcr.io/k8s-staging-metrics-server/metrics-server": getting dependencies for "gcr.io/k8s-staging-metrics-server/metrics-server": parsing ONBUILD instructions: retrieving image "golang:1.23.4": GET https://index.docker.io/v2/library/golang/manifests/sha256:ccdca3b3bde3bfee2518a087b467f2b452fad9ba3e378d3c1578db494c8cb13b: TOOMANYREQUESTS: You have reached your unauthenticated pull rate limit. https://www.docker.com/increase-rate-limit

/test pull-metrics-server-test-e2e

@RainbowMango
Copy link
Member

/test pull-metrics-server-test-e2e-ha

@RainbowMango
Copy link
Member

It's weird that I can't reproduce it on my side:

-bash-5.0# make verify-lint
make: command: Command not found
make: command: Command not found
make: command: Command not found
make: command: Command not found
curl -sSfL https://raw.githubusercontent.com/golangci/golangci-lint/master/install.sh | sh -s -- -b /root/go/bin v1.61.0
golangci/golangci-lint info checking GitHub for tag 'v1.61.0'
golangci/golangci-lint info found version: 1.61.0 for v1.61.0/linux/amd64
golangci/golangci-lint info installed /root/go/bin/golangci-lint
/root/go/bin/golangci-lint run --timeout 10m || (echo 'Run "make update"' && exit 1)
WARN The linter 'exportloopref' is deprecated (since v1.60.2) due to: Since Go1.22 (loopvar) this linter is no longer relevant. Replaced by copyloopvar. 
-bash-5.0# echo $?
0

@RainbowMango RainbowMango mentioned this pull request Mar 21, 2025
Merged
@RainbowMango
Copy link
Member

@dgrisonnet Can you help rebase this one more time? It should be OK now.

@dgrisonnet
Copy link
Member

@dependabot rebase

@dependabot
build(deps): bump actions/checkout from 4.2.0 to 4.2.2

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: B5690EEEBB952194
Verified
Learn about vigilant mode
Loading
Loading status checks…
2e19070 
Bumps [actions/checkout](https://github.com/actions/checkout) from 4.2.0 to 4.2.2.
- [Release notes](https://github.com/actions/checkout/releases)
- [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md)
- [Commits](actions/checkout@d632683...11bd719)

---
updated-dependencies:
- dependency-name: actions/checkout
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot force-pushed the dependabot/github_actions/actions/checkout-4.2.2 branch from 838f0a6 to 2e19070 Compare March 27, 2025 11:36
@dgrisonnet
Copy link
Member

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 27, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dependabot[bot], dgrisonnet, yangjunmyfm192085

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 2aa7c01 into master Mar 27, 2025
11 checks passed
@dependabot dependabot bot deleted the dependabot/github_actions/actions/checkout-4.2.2 branch March 27, 2025 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yangjunmyfm192085 yangjunmyfm192085

@dgrisonnet dgrisonnet

@s-urbaniak s-urbaniak

Assignees

@dgrisonnet dgrisonnet

@yangjunmyfm192085 yangjunmyfm192085

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. dependencies Pull requests that update a dependency file github_actions Pull requests that update GitHub Actions code lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@k8s-ci-robot @richabanker @k8s-triage-robot @RainbowMango @dgrisonnet @yangjunmyfm192085