Use create jobs command instead of run pods in e2e testing #445
+38
−38
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
kind/cleanup
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
the
size/M
✅ Deploy Preview for kubernetes-sigs-lws canceled.
|
|
@Edwinhr716 @kerthcet would you mind having a look at this PR, when you have a chance?. |
Edwinhr716
reviewed
Mar 18, 2025
test/e2e/e2e_test.go
Outdated
| @@ -363,23 +363,23 @@ var _ = ginkgo.Describe("leaderWorkerSet e2e tests", func() { | |||
| gomega.Eventually(verifyMetricsServerStarted).Should(gomega.Succeed()) | |||
|
|
|||
| ginkgo.By("creating the curl-metrics pod to access the metrics endpoint") | |||
There was a problem hiding this comment.
Thank you for review. Updated.
ardaguclu
force-pushed
the
use-create-jobs
branch
from
e7a9686 to
8e65839
Compare
curl-metrics test tries to run a curl command to collect the metrics and it is intended to be short lived. This is typical use case for jobs rather than pods. This commit modifies the test to run job by using kubectl create job command. Besides, kubectl run is not recommended.
Default nginx image requires privileged access in the pod which is unwanted and not recommended even in testing environments. This commit switches to nginxinc/nginx-unprivileged that installs nginx in an unprivileged way. This commit also updates the nginx version to 1.27 instead of the very old 1.14.2
ardaguclu
force-pushed
the
use-create-jobs
branch
from
8e65839 to
f49e150
Compare
|
This is known flakiness |
|
I will try to investigate the flakiness tomorrow |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ardaguclu, kerthcet The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind cleanup
What this PR does / why we need it
curl-metrics test tries to run a curl command to collect the metrics and
it is intended to be short lived. This is typical use case for jobs rather
than pods. This PR modifies the test to run job by using
kubectl create jobcommand. Besides, kubectl run is not recommended.
Additionally, Default nginx image requires privileged access in the pod which is
unwanted and not recommended even in testing environments.
This PR switches to
nginxinc/nginx-unprivilegedthat installs nginxin an unprivileged way. This PR also updates the nginx version to 1.27
instead of the very old 1.14.2 (we only need to update the e2e tests, but just to
align all the pieces, this PR switches everywhere to the same version).
This PR must no affect on any functionality or any test.
Does this PR introduce a user-facing change?