Skip to content

Fix website layout #450

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 20, 2025
Merged

Conversation

Edwinhr716
Copy link
Contributor

What type of PR is this?

/kind bug

What this PR does / why we need it

After the changes introduced in #446, it causes a visual bug

Screenshot 2025-03-18 at 4 35 28 PM

This is how it looks like after the fix

Screenshot 2025-03-18 at 4 36 45 PM

Which issue(s) this PR fixes

Fixes #

Special notes for your reviewer

Does this PR introduce a user-facing change?


@Edwinhr716 Edwinhr716 requested a review from kerthcet March 18, 2025 23:52
@k8s-ci-robot k8s-ci-robot added the kind/bug Categorizes issue or PR as related to a bug. label Mar 18, 2025
@k8s-ci-robot k8s-ci-robot requested a review from ahg-g March 18, 2025 23:52
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Edwinhr716

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Mar 18, 2025
Copy link

netlify bot commented Mar 18, 2025

Deploy Preview for kubernetes-sigs-lws ready!

Name Link
🔨 Latest commit ef27a76
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-lws/deploys/67da07512e6bef0008c94427
😎 Deploy Preview https://deploy-preview-450--kubernetes-sigs-lws.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@ahg-g
Copy link
Contributor

ahg-g commented Mar 19, 2025

The page references wg-batch as well instead of wg-serving, can we pls fix that?

@Edwinhr716
Copy link
Contributor Author

Where? I kept the changes made in #446, just changed the indentation

Copy link
Contributor

@kerthcet kerthcet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 20, 2025
@kerthcet
Copy link
Contributor

Fixed one place before, hasn't found any other places.

@k8s-ci-robot k8s-ci-robot merged commit ebbf42e into kubernetes-sigs:main Mar 20, 2025
9 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants