Skip to content

Export kind and cluster related logs under artifacts directory for e2e #451

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 19, 2025
Merged

Export kind and cluster related logs under artifacts directory for e2e #451

merged 1 commit into from
Mar 19, 2025
+12 −1

Conversation

ardaguclu
Copy link
Contributor

What type of PR is this?

/kind cleanup

What this PR does / why we need it

While investigating #437, I realized that there is almost no logs making the troubleshooting easier (e.g. https://gcsweb.k8s.io/gcs/kubernetes-ci-logs/pr-logs/pull/kubernetes-sigs_lws/445/pull-lws-test-e2e-main-1-31/1902041411415445504/artifacts/).

This PR exporting kind and cluster related logs under artifacts directory to troubleshoot any issues including the flaky one that I'm looking right now.

This PR mimics from jobset https://github.com/kubernetes-sigs/jobset/blob/15adf20ce9e0a10f01e7bcd8ea585a011814a2aa/hack/e2e-test.sh#L14-L17

Does this PR introduce a user-facing change?

None

@k8s-ci-robot k8s-ci-robot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Mar 19, 2025
@netlify Netlify
Copy link

netlify bot commented Mar 19, 2025 •
edited
Loading

✅ Deploy Preview for kubernetes-sigs-lws canceled.

Name Link
🔨 Latest commit cec6956
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-lws/deploys/67da65930086130008a496c3

@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Mar 19, 2025
@ardaguclu
Copy link
Contributor Author

Logs https://gcsweb.k8s.io/gcs/kubernetes-ci-logs/pr-logs/pull/kubernetes-sigs_lws/451/pull-lws-test-e2e-main-1-30/1902247411548426240/artifacts/ are collected correctly.

This PR is ready for review.

kerthcet
kerthcet reviewed Mar 19, 2025
View reviewed changes
Copy link
Contributor

@kerthcet kerthcet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm thinking whether we should make it a flag rather than exposing logs all the time, but let's find the root cause first.
/lgtm
/approve

Thanks!

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 19, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ardaguclu, kerthcet

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 19, 2025
@ardaguclu
Copy link
Contributor Author

I'm thinking whether we should make it a flag rather than exposing logs all the time, but let's find the root cause first. /lgtm /approve

Thanks!

That is a good point. What about we collect the logs if the exit code of ginkgo execution is non-zero?. That would be better in my opinion and I can open a followup PR.

@k8s-ci-robot k8s-ci-robot merged commit 8c57c6d into kubernetes-sigs:main Mar 19, 2025
12 checks passed
@ardaguclu ardaguclu deleted the export-kind-logs branch March 19, 2025 09:57
@ardaguclu ardaguclu mentioned this pull request Mar 19, 2025
Closed
@kerthcet kerthcet mentioned this pull request Mar 26, 2025
Closed
19 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kerthcet kerthcet

@Edwinhr716 Edwinhr716

Assignees

@kerthcet kerthcet

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ardaguclu @k8s-ci-robot @kerthcet