Skip to content

Fix post-kueue-push-images. #4773

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 24, 2025

Conversation

mbobrovskyi
Copy link
Contributor

@mbobrovskyi mbobrovskyi commented Mar 24, 2025

What type of PR is this?

/kind bug

What this PR does / why we need it:

We have an issue in post-kueue-push-images:

make: *** No rule to make target 'kueue-viz-image-push'.  Stop.
ERROR
ERROR: build step 0 "gcr.io/k8s-staging-test-infra/gcb-docker-gcloud:v20240718-5ef92b5c36" failed: step exited with non-zero status: 2

It happens after #4753.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

https://prow.k8s.io/view/gs/kubernetes-ci-logs/logs/post-kueue-push-images/1904115121601384448

Does this PR introduce a user-facing change?

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/bug Categorizes issue or PR as related to a bug. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Mar 24, 2025
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Mar 24, 2025
Copy link

netlify bot commented Mar 24, 2025

Deploy Preview for kubernetes-sigs-kueue ready!

Name Link
🔨 Latest commit a4c3d69
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-kueue/deploys/67e14c05d71cfc0008f00dfd
😎 Deploy Preview https://deploy-preview-4773--kubernetes-sigs-kueue.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@mbobrovskyi
Copy link
Contributor Author

/cc @mimowo @akram

@k8s-ci-robot k8s-ci-robot requested review from akram and mimowo March 24, 2025 12:12
@mimowo
Copy link
Contributor

mimowo commented Mar 24, 2025

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 24, 2025
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 4c2f07bf50b463caa688e77f30e1e06f93d84124

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mbobrovskyi, mimowo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 24, 2025
@k8s-ci-robot k8s-ci-robot merged commit 848b8ee into kubernetes-sigs:main Mar 24, 2025
21 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v0.12 milestone Mar 24, 2025
@mbobrovskyi mbobrovskyi deleted the fix/post-kueue-push-images branch March 24, 2025 13:25
@akram
Copy link
Contributor

akram commented Mar 24, 2025

thanks @mbobrovskyi for fixing that

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants